Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link spans to Embrace session by id #183

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Link spans to Embrace session by id #183

merged 3 commits into from
Feb 24, 2025

Conversation

NachoEmbrace
Copy link
Contributor

This will allow user generated spans that fall outside the session to be included in it.

  • Adds a new optional session_identifier column to `SpanRecord``
  • When fetching spans for a given session, this identifier will be used to find a match
  • If the stored id is nil or doesn't match, it will fallback to the old logic that checks the start and end times.

@NachoEmbrace NachoEmbrace marked this pull request as ready for review February 20, 2025 18:19
@NachoEmbrace NachoEmbrace requested a review from a team as a code owner February 20, 2025 18:19
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

Warnings
⚠️ No CHANGELOG entry added.

Generated by 🚫 Danger Swift against 79888da

@NachoEmbrace NachoEmbrace merged commit 3a12679 into main Feb 24, 2025
6 of 8 checks passed
@NachoEmbrace NachoEmbrace deleted the session_id_on_spans branch February 24, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants